Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updated joi, express #159

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

updated joi, express #159

wants to merge 3 commits into from

Conversation

vitalii-codefresh
Copy link

No description provided.

yaroslav-codefresh
yaroslav-codefresh reviewed May 13, 2024
View reviewed changes
infra/express.js
@@ -1,15 +1,12 @@

const Promise = require('bluebird');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please return

@yaroslav-codefresh
Copy link
Member

  1. updating Joi with 4 major versions will require to go over all breaking changes through the changelog and checking if something can be potentially broken in pipeline-manager, context-manager and runtime-environment-manager
  2. throw error from validate wrapper

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaroslav-codefresh yaroslav-codefresh yaroslav-codefresh left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vitalii-codefresh @yaroslav-codefresh