bring latest #5
Open
bring latest #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat(included): generate new image with version 12.0.0 * fix tests
* Clean up apt-get artifacts to reduce image sizes Updates the Dockerfile generation scripts to include cleanup for apt-get's extraneous artifacts This removes 30 MB from the base family and 20 MB from the included family. In production, it will reduce the included family by 50 MB because it will inherit 30 MB less from the base family + 20 MB reduction in the image itself. There's a lot of bloat in the browsers family of images. They have several RUN commands that call apt-get and fail to clean up, so there's a few hundred MB of bloat from those in the final included family. It's hard to fix at this point because we don't have generators for them and we don't want to modify the image tags already published. * Add --no-install-recommends to apt upgrade call * Delete obsolete scripts * Add back example comand * Apply image minimization to scripts
* in progress * latest updates * latest changes * Second attempt * Latest changes * Remove original docker factory * Rename second factory iteration to factory * Fixes for installing chrome and cypress standalone * add test project * more test cases * readme updates mostly * readme update * remove unused factory test. * naming docker images in docker compose * Clean up some todos, add webkit install step * rename install scripts * minor updates * use edge stable * docs and edge version update * add tags * use ENV instead of yml anchors * testing circle build * new image??? * try again * check envs * experiment * just update bash_env * more testing * maybe this * i don't think this is going to work * ? * maybe we need to make it first? * ? * :/ * >:( * derp * use current directory * buildx * override platform * load docker images * more experiments * target isn't a key word * grumpy * actually load arm64 version * testing? * circle syntax * once again * try this * try testing arm64?? * random buildkit workaround??? * more robust env setting * can't inspect i guess * try it again without syntax errors * try using buildx * yml * try docker driver because i don't want to run a local registry 😭 * make a new builder * try with a local registry??? * testing * Try pushing to a local repo * fiddle fiddle * wait longer i guess * oops typo * try it on an arm machine * env * yay it failed like it should have! * lol, i bet this fails due to something dumb * told you so * typo * colon * schema violations, i'll be back * maybe this? * don't matrix resource class * no s * fix syntax * lots of changes so low probability that this works right off. * fix some typos and rename some things. * run all commands on all included * i <3 yaml * combine again * not a string * combine into one workflow * conditional testing * alias * alias in the right place * changes around building images to get us ready for pushing. * name syntax error? * maybe this? * yml is great * remove dead end * missed a colon * omg * use correct env * fix browsers push job * update halt if exist * un-comment workflows * don't use undeclared parameters * circle cleanup * more cleanup * reduce more * i had to mess something up * minor updates * update comment * check versions * remove params * try again * check against the right version * check cypress version * new included image version string * clean up * updated notes on env file * Self review changes * more self review changes * remove test project and test folder * Updated readme * updating contributing guide * tweak * note * Remove scripts * Apply suggestions from code review Co-authored-by: Emily Rohrbough <[email protected]> * pr updates * update * Apply suggestions from code review Co-authored-by: Emily Rohrbough <[email protected]> * Moved api up * specify further in api * use inherit for logging * adding example reducing the size of the docker container. * update default version location * Update factory/README.md Co-authored-by: Emily Rohrbough <[email protected]> * changing command to docker compose from docker-compose * Adding instructions to build locally to the contributing document. * adding context to push jobs * use newest cypress version * add no_output_timeout for included container. * move timeout * release latest tag for the factory * Apply suggestions from code review Co-authored-by: Paul Jaffre <[email protected]> * Update factory/README.md * Update factory/README.md Co-authored-by: Paul Jaffre <[email protected]> * Update factory/README.md * Update factory/README.md * Update factory/README.md * Apply suggestions from code review Co-authored-by: Paul Jaffre <[email protected]> * add brief one off release instructions. * try quotes * more quotes * fix versions test * try it again * PR Feedback Co-authored-by: Emily Rohrbough <[email protected]> Co-authored-by: Paul Jaffre <[email protected]>
* update browser versions * echo out confirmed version
* fix: apply node version arg from dockerfile * string command * also release a fix when merged. * case sensitive * pr feedback * add comment
* fix: add ps command * improve comment * Add changelog
* add security best practice note * add PR feedback & reword a bit
* break all the tests * try permissive privs * testing to get included working with a non root user * theoretically this will work * whoops * typo * test on amd64 too * add a wordy comment * Update factory/installScripts/cypress/default.sh Co-authored-by: Bill Glesias <[email protected]> --------- Co-authored-by: Bill Glesias <[email protected]>
* update browser versions * update chrome and edge browser versions * revert herp derp
add issue to triage board workflow
* fix: bump Node.js 18.14.1 * Update factory/.env --------- Co-authored-by: Matt Henkes <[email protected]>
* chore: update change log for cypress/factory * Apply suggestions from code review Co-authored-by: Bill Glesias <[email protected]> --------- Co-authored-by: Bill Glesias <[email protected]>
* chore: add internal 20.18.0 chrome 130 and firefox 131 image * chore: add internal 20.18.0 chrome 129 and firefox 131 image * fix typo
* chore: add internal 20.18.0 chrome 130 and firefox 131 image * chore: add internal 20.18.0 chrome 129 and firefox 131 image * fix typo * chore: fix internal node20.18.0-chrome129-ff131
Updates: - FACTORY_VERSION to 5.0.0 - FACTORY_DEFAULT_NODE_VERSION to 22.11.0 - EDGE_VERSION to 130.0.2849.56-1 - FIREFOX_VERSION 132.0
* feat: add BROWSERS_IMAGE_SHORT_TAG * BROWSERS_IMAGE_SHORT_TAG usable for alternate versions * chore: minor chrome and edge version update Update - CHROME_VERSION to 131.0.6778.85-1 - EDGE_VERSION to 131.0.2903.70-1
Include usage of new BROWSERS_IMAGE_SHORT_TAG
Update FACTORY_VERSION from 5.1.0 to 5.1.1 FACTORY_DEFAULT_NODE_VERSION from 22.11.0 to 22.12.0 CHROME_VERSION from 131.0.6778.85-1 to 131.0.6778.108-1 FIREFOX_VERSION from 132.0.2 to 133.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.