fix(secrets): fix an issue with secret server listening on IPv6 #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-logger into CR-24332-secret-store-regression
|
/e2e |
masontikhonov
force-pushed
the
CR-24332-secret-store-regression
branch
from
2e6feca to
9fbeeee
Compare
masontikhonov
force-pushed
the
CR-24332-secret-store-regression
branch
from
58f59cc to
cb4b05b
Compare
|
/e2e |
masontikhonov
force-pushed
the
CR-24332-secret-store-regression
branch
from
693a884 to
b2d1d07
Compare
|
/e2e |
ATGardner
approved these changes
Jul 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This fixes possible issues with any discrepancy between the address at which Logger is listening for mask requests; and the address that is used to call this server.
./lib/addNewMask.jsscript does not rely on env variables nor default values anymore. Instead, it reads server address from the FS where it should have been written by the server. If server address is missing, the script throws.The default server host changed from
localhostto0.0.0.0.Fixed secrets-to-be-masked leak in the
cf-container-loggerserver logs.Added a safeguard for arbitrary process exit with zero code before masking variables, which will lead to the leakage of unmasked secrets in the build logs.
Why
—
Notes
—
Labels
Assign the following labels to the PR:
security- to trigger image scanning in CI buildPR Comments
Add the following comments to the PR:
/e2e- to trigger E2E build