Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Additional logs for application versions #283

Merged
merged 2 commits into from
Feb 7, 2024

Conversation

andrii-codefresh
Copy link

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.

Copy link

codecov bot commented Feb 7, 2024

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (a033488) 46.73% compared to head (0098f2a) 46.73%.

Files Patch % Lines
reposerver/repository/app_version.go 0.00% 3 Missing ⚠️
reposerver/repository/repository.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           release-2.9     #283      +/-   ##
===============================================
- Coverage        46.73%   46.73%   -0.01%     
===============================================
  Files              277      277              
  Lines            33650    33655       +5     
===============================================
  Hits             15728    15728              
- Misses           15822    15827       +5     
  Partials          2100     2100              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrii-codefresh andrii-codefresh changed the title Add logs feat: Additional logs for application versions Feb 7, 2024
@andrii-codefresh andrii-codefresh merged commit 9d27fc1 into release-2.9 Feb 7, 2024
12 of 13 checks passed
oleksandr-codefresh added a commit that referenced this pull request Feb 8, 2024
oleksandr-codefresh added a commit that referenced this pull request Feb 8, 2024
oleksandr-codefresh added a commit that referenced this pull request Feb 8, 2024
* Revert "feat: Additional logs for application versions  (#283)"

This reverts commit 9d27fc1

* Revert "feat: version config (#279)"

This reverts commit 2d48b28

* Revert "fix:CR-22268-vuln-fix (#278)"

This reverts commit ccd7124

* CHANGELOG.md

* trigger
andrii-codefresh added a commit that referenced this pull request Feb 9, 2024
@ATGardner ATGardner deleted the CR-21694-app-vers-logs branch July 18, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants