Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Application versions #240

Merged
merged 9 commits into from
Oct 23, 2023
Merged

Conversation

andrii-codefresh
Copy link

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.

Please see Contribution FAQs if you have questions about your pull-request.

@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

Attention: 91 lines in your changes are missing coverage. Please review.

Files Coverage Δ
controller/state.go 67.47% <100.00%> (+0.07%) ⬆️
server/application/application.go 48.19% <100.00%> (-0.19%) ⬇️
util/argo/argo.go 67.33% <100.00%> (+0.06%) ⬆️
reposerver/repository/repository.go 0.00% <0.00%> (ø)
server/application/application_event_reporter.go 27.05% <38.70%> (+0.59%) ⬆️
reposerver/repository/app_version.go 0.00% <0.00%> (ø)

... and 4 files with indirect coverage changes

📢 Thoughts on this report? Let us know!.

controller/state.go Outdated Show resolved Hide resolved
pkg/version_config_manager/version_config_manager.go Outdated Show resolved Hide resolved
pkg/version_config_manager/version_config_manager.go Outdated Show resolved Hide resolved
pkg/version_config_manager/version_config_manager.go Outdated Show resolved Hide resolved
reposerver/repository/app_version.go Outdated Show resolved Hide resolved
reposerver/repository/app_version.go Outdated Show resolved Hide resolved
reposerver/repository/repository.proto Show resolved Hide resolved
server/application/application_event_reporter.go Outdated Show resolved Hide resolved
server/application/application_event_reporter.go Outdated Show resolved Hide resolved
server/application/events.proto Show resolved Hide resolved
@andrii-codefresh andrii-codefresh changed the title argo-cd logic (controller, server, reposerver) feat: Application versions Oct 20, 2023

versionConfig, err := versionConfigManager.ObtainConfig()
if err != nil {
log.Printf("ERROR: Failed to obtain config: %v", err)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same, please also remove Error:

@pasha-codefresh pasha-codefresh merged commit 6df3292 into release-2.8 Oct 23, 2023
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants