feat: support creation of apps with empty dir

codefresh-io · Dec 4, 2023 · dede45e · dede45e
1 parent a858ad3
commit dede45e
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/event_reporter/reporter/application_event_reporter.go b/event_reporter/reporter/application_event_reporter.go
@@ -125,11 +125,15 @@ func (r *applicationEventReporter) getDesiredManifests(ctx context.Context, a *a
 	})
 	if err != nil {
 		notManifestGenerationError := !strings.Contains(err.Error(), "Manifest generation error")
+
+		// we can ignore the error
+		notAppPathDoesntExistsError := !strings.Contains(err.Error(), "app path does not exist")
+
 		// when application deleted rbac also throws erorr with PermissionDenied
 		// we can ignore the error, as we check rbac access before reporting events
 		notPermissionDeniedError := !strings.Contains(err.Error(), "PermissionDenied")
 
-		if notManifestGenerationError && notPermissionDeniedError {
+		if notManifestGenerationError && notPermissionDeniedError && notAppPathDoesntExistsError {
 			return nil, fmt.Errorf("failed to get application desired state manifests: %w", err), false
 		}
 		// if it's manifest generation error we need to still report the actual state