event-reporter: added app warning conditions reporting

changelog/CHANGELOG.md

@@ -1,2 +1,2 @@
 ### Features
--  feat: manage clusters via proxy
+-  feat(event-reporter): added warning conditions reporting

event_reporter/reporter/application_errors_parser.go

@@ -39,10 +39,6 @@ func parseApplicationSyncResultErrorsFromConditions(status appv1.ApplicationStat
 		return errs
 	}
 	for _, cnd := range status.Conditions {
-		if !strings.Contains(strings.ToLower(cnd.Type), "error") {
-			continue
-		}
-
 		lastSeen := metav1.Now()
 		if cnd.LastTransitionTime != nil {
 			lastSeen = *cnd.LastTransitionTime
@@ -52,10 +48,13 @@ func parseApplicationSyncResultErrorsFromConditions(status appv1.ApplicationStat
 			resourcesSyncErrors := parseAggregativeResourcesSyncErrors(status.OperationState.SyncResult.Resources)
 
 			errs = append(errs, resourcesSyncErrors...)
-		} else {
+			continue
+		}
+
+		if cnd.IsError() || cnd.IsWarning() {
 			errs = append(errs, &events.ObjectError{
 				Type:     "sync",
-				Level:    "error",
+				Level:    getConditionLevel(cnd),
 				Message:  cnd.Message,
 				LastSeen: lastSeen,
 			})
@@ -64,6 +63,16 @@ func parseApplicationSyncResultErrorsFromConditions(status appv1.ApplicationStat
 	return errs
 }
 
+func getConditionLevel(cnd appv1.ApplicationCondition) string {
+	if cnd.IsWarning() {
+		return "warning"
+	}
+	if cnd.IsWarning() {
+		return "error"
+	}
+	return ""
+}
+
 func parseResourceSyncResultErrors(rs *appv1.ResourceStatus, os *appv1.OperationState) []*events.ObjectError {
 	errors := []*events.ObjectError{}
 	if os.SyncResult == nil {
@@ -133,7 +142,7 @@ func parseAggregativeHealthErrors(rs *appv1.ResourceStatus, apptree *appv1.Appli
 			}
 
 			if addReference {
-				newErr.SourceReference = events.ErrorSourceReference{
+				newErr.SourceReference = &events.ErrorSourceReference{
 					Group:     rs.Group,
 					Version:   rs.Version,
 					Kind:      rs.Kind,

event_reporter/reporter/applications_errors_parser_test.go

@@ -142,7 +142,7 @@ func TestParseApplicationSyncResultErrorsFromConditions(t *testing.T) {
 		errors := parseApplicationSyncResultErrorsFromConditions(v1alpha1.ApplicationStatus{
 			Conditions: []v1alpha1.ApplicationCondition{
 				{
-					Type:    "error",
+					Type:    v1alpha1.ApplicationConditionSyncError,
 					Message: "error message",
 				},
 			},
@@ -154,11 +154,27 @@ func TestParseApplicationSyncResultErrorsFromConditions(t *testing.T) {
 		assert.Equal(t, "error", errors[0].Level)
 	})
 
+	t.Run("warning exists", func(t *testing.T) {
+		errors := parseApplicationSyncResultErrorsFromConditions(v1alpha1.ApplicationStatus{
+			Conditions: []v1alpha1.ApplicationCondition{
+				{
+					Type:    v1alpha1.ApplicationConditionOrphanedResourceWarning,
+					Message: "Application has 8 orphaned resources",
+				},
+			},
+		})
+
+		assert.Len(t, errors, 1)
+		assert.Equal(t, "Application has 8 orphaned resources", errors[0].Message)
+		assert.Equal(t, "sync", errors[0].Type)
+		assert.Equal(t, "warning", errors[0].Level)
+	})
+
 	t.Run("conditions erorr replaced with sync result errors", func(t *testing.T) {
 		errors := parseApplicationSyncResultErrorsFromConditions(v1alpha1.ApplicationStatus{
 			Conditions: []v1alpha1.ApplicationCondition{
 				{
-					Type:    "error",
+					Type:    v1alpha1.ApplicationConditionSyncError,
 					Message: syncTaskUnsuccessfullErrorMessage,
 				},
 			},

pkg/apis/application/v1alpha1/types.go

@@ -2869,6 +2869,11 @@ func (condition *ApplicationCondition) IsError() bool {
 	return strings.HasSuffix(condition.Type, "Error")
 }
 
+// IsWarning returns true if a condition indicates an warning condition
+func (condition *ApplicationCondition) IsWarning() bool {
+	return strings.HasSuffix(condition.Type, "Warning")
+}
+
 // Equals compares two instances of ApplicationSource and return true if instances are equal.
 func (source *ApplicationSource) Equals(other *ApplicationSource) bool {
 	if source == nil && other == nil {