Skip to content

Commit

Permalink
handle single history item
Browse files Browse the repository at this point in the history
  • Loading branch information
pasha-codefresh committed Oct 16, 2024
1 parent 97d82af commit 2e35fd8
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion acr_controller/service/acr_service_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -243,7 +243,7 @@ func Test_getRevisions(r *testing.T) {
assert.Equal(t, "c732f4d2ef24c7eeb900e9211ff98f90bb646505", current)
assert.Equal(t, "", previous)
})

r.Run("application is synced", func(t *testing.T) {
acrService := newTestACRService(&mocks.ApplicationClient{})
app := createTestApp(syncedAppWithHistory)
Expand Down
2 changes: 1 addition & 1 deletion util/git/client.go
Original file line number Diff line number Diff line change
Expand Up @@ -911,7 +911,7 @@ func (m *nativeGitClient) ListRevisions(revision string, targetRevision string)
if revision == "" {
return []string{targetRevision}, nil
}

if !IsCommitSHA(revision) || !IsCommitSHA(targetRevision) {
return nil, fmt.Errorf("invalid revision provided, must be SHA")
}
Expand Down

0 comments on commit 2e35fd8

Please sign in to comment.