fixed app deletion events sometimes not being sent (#87)

codefresh-io · May 11, 2022 · 2b915fe · 2b915fe
1 parent 2167dba
commit 2b915fe
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/VERSION b/VERSION
@@ -1 +1 @@
-2.1.14-cap-CR-11584-fix-resource-cache
+2.1.14-cap-CR-11708-send-app-deletion
diff --git a/server/application/application.go b/server/application/application.go
@@ -905,6 +905,11 @@ func (s *Server) StartEventSource(es *events.EventSource, stream events.Eventing
 func (s *Server) shouldSendApplicationEvent(ae *appv1.ApplicationWatchEvent) bool {
 	logCtx := log.WithField("application", ae.Application.Name)
 
+	if ae.Type == watch.Deleted {
+		logCtx.Info("application deleted")
+		return true
+	}
+
 	cachedApp, err := s.cache.GetLastApplicationEvent(&ae.Application)
 	if err != nil || cachedApp == nil {
 		return true
Original file line number	Diff line number	Diff line change
		@@ -1 +1 @@
		2.1.14-cap-CR-11584-fix-resource-cache
		2.1.14-cap-CR-11708-send-app-deletion