Performance improvement: Vueファイルのダイナミックインポート対応 #408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for code-for-sappor-covid19-deploy-preview-free ready! Built with commit c89bde1 https://deploy-preview-408--code-for-sappor-covid19-deploy-preview-free.netlify.app |
|
詳しくないのですが、これはどういったメリットがある変更なのでしょうか？ |
|
Vueのコンポーネント類が非同期で読まれるようになるので少しパフォーマンスが向上するかと思いますー |
|
読み込まれてるjsファイルが増えたので、理論上は効いてるきがする・・
一応新し目の機能なので、各ブラウザ確認注意してリリースしましょう |
|
動作確認完了のためマージ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 関連issue
⛏ 変更内容
📸 スクリーンショット