Fix linter behavior for RPGLEINC files #340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: worksofliam <[email protected]>
Signed-off-by: worksofliam <[email protected]>
Signed-off-by: worksofliam <[email protected]>
|
Thanks @worksofliam ! But, I'm not on v0.26.13 and it's still firing on my source which is RPGLEINC. Did I misunderstand and this isn't out yet? |
|
@Gregory1701 are you working in a source member, stream file or local? |
|
old fashioned source member, my friend. It's in QCPYSRC. |
|
@Gregory1701 what is the attribute/extension of the member? |
|
@Gregory1701 Additional fix, 0.26.14, is out now, which solves this issue. I forgot member attributes in VS Code as not very simple. |
|
Thanks @worksofliam , it's better, but still throwing one error. Is that intentional? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The linter now correctly ignores specified rules when processing RPGLEINC files, addressing the issue where it was incorrectly firing on these include files. A test case has been added to verify this behavior. Unused log statements have also been removed for cleaner code.
Fixes #338