Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(getIncludeFromDirective): ignore the comment line #335

Merged
merged 3 commits into from
Dec 2, 2024

Conversation

sebCIL
Copy link
Contributor

@sebCIL sebCIL commented Oct 22, 2024

Changes

/include or /copy does not work if there is a comment on the line.

Checklist

  • have tested my change
  • updated relevant documentation
  • Remove any/all console.logs I added
  • eslint is not complaining
  • have added myself to the contributors' list in the README
  • for feature PRs: PR only includes one feature enhancement.

@worksofliam
Copy link
Contributor

@sebCIL Can you provide a test case for this?

@sebCIL
Copy link
Contributor Author

sebCIL commented Oct 28, 2024

I'm not sure where to put the test...
I have made a modification

@sebCIL
Copy link
Contributor Author

sebCIL commented Nov 27, 2024

is it ok ?

@worksofliam
Copy link
Contributor

@sebCIL Sorry for the delay. I will look this week!

Signed-off-by: worksofliam <[email protected]>
@worksofliam
Copy link
Contributor

@sebCIL I made one blank new line - thanks for the test case! Let's merge!

@worksofliam worksofliam merged commit c47c53f into codefori:main Dec 2, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants