Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lowercase directives followup #298

Merged
merged 4 commits into from
Mar 20, 2024

Conversation

richardm90
Copy link
Contributor

Changes

Followup to PR #283.

  1. Removed the UppercaseDirectives linter option from the code base.
  2. Fixed the use of the new DirectiveCase linter option. Most references used DirectiveCasing, now all references use DirectiveCase.

Checklist

  • have tested my change
  • updated relevant documentation
  • Remove any/all console.logs I added
  • eslint is not complaining
  • have added myself to the contributors' list in the README
  • for feature PRs: PR only includes one feature enhancement.

@worksofliam worksofliam self-requested a review February 29, 2024 18:36
@worksofliam
Copy link
Contributor

@richardm90 Sorry my friend - any chance you can fix the conflicts here? I switched out our ugly test suite for a brand new one using vitest, which works across all platforms now!

Copy link
Contributor

@worksofliam worksofliam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix conflicts please!

@richardm90
Copy link
Contributor Author

Fix conflicts please!

Will do.

@richardm90
Copy link
Contributor Author

Fixed conflicts

@richardm90 richardm90 requested a review from worksofliam March 18, 2024 21:34
Copy link
Contributor

@worksofliam worksofliam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @richardm90 !!

@worksofliam worksofliam merged commit 01825f7 into codefori:main Mar 20, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants