Implement #18

codefori · Nov 18, 2021 · 4ce7969 · 4ce7969
1 parent bde803e
commit 4ce7969
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 1 deletion.
diff --git a/src/linter.js b/src/linter.js
@@ -23,6 +23,7 @@ const errorText = {
   'RequireBlankSpecial': `\`*BLANK\` should be used over empty string literals.`,
   'CopybookDirective': `Directive does not match requirement.`,
   'UppercaseDirectives': `Directives must be in uppercase.`,
+  'NoSQLJoins': `SQL joins are not allowed. Consider creating a view instead.`,
 }
 
 module.exports = class Linter {
@@ -49,6 +50,7 @@ module.exports = class Linter {
    *  RequireBlankSpecial?: boolean,
    *  CopybookDirective?: "copy"|"include"
    *  UppercaseDirectives?: boolean,
+   *  NoSQLJoins?: boolean,
    *  SpecificCasing?: {operation: string, expected: string}[],
    * }} rules 
    * @param {Cache|null} [definitions]
@@ -79,7 +81,12 @@ module.exports = class Linter {
     /** @type {{
      *  range: vscode.Range, 
      *  offset?: {position: number, length: number}
-     *  type: "BlankStructNamesCheck"|"QualifiedCheck"|"PrototypeCheck"|"ForceOptionalParens"|"NoOCCURS"|"NoSELECTAll"|"UselessOperationCheck"|"UppercaseConstants"|"SpecificCasing"|"InvalidDeclareNumber"|"IncorrectVariableCase"|"RequiresParameter"|"RequiresProcedureDescription"|"StringLiteralDupe"|"RequireBlankSpecial"|"CopybookDirective"|"UppercaseDirectives", 
+     *  type: 
+     *      "BlankStructNamesCheck"|"QualifiedCheck"|"PrototypeCheck"|"ForceOptionalParens"|
+     *      "NoOCCURS"|"NoSELECTAll"|"UselessOperationCheck"|"UppercaseConstants"|"SpecificCasing"|
+     *      "InvalidDeclareNumber"|"IncorrectVariableCase"|"RequiresParameter"|
+     *      "RequiresProcedureDescription"|"StringLiteralDupe"|"RequireBlankSpecial"|
+     *      "CopybookDirective"|"UppercaseDirectives"|"NoSQLJoins", 
      *  newValue?: string}[]
      * } */
     let errors = [];
@@ -347,6 +354,15 @@ module.exports = class Linter {
                     });
                   }
                 }
+
+                if (rules.NoSQLJoins) {
+                  if (statement.some(part => part.value && part.value.toUpperCase() === `JOIN`)) {
+                    errors.push({
+                      range: new vscode.Range(statementStart, statementEnd),
+                      type: `NoSQLJoins`
+                    });
+                  }
+                }
                 break;
 
               case `IF`:

diff --git a/src/schemas/rpglint.json b/src/schemas/rpglint.json
@@ -81,6 +81,11 @@
             "type": "boolean",
             "description": "Directives must be in uppercase."
         },
+        "NoSQLJoins": {
+            "$id": "#/properties/NoSQLJoins",
+            "type": "boolean",
+            "description": "JOINs in Embedded SQL are not allowed."
+        },
         "SpecificCasing": {
             "$id": "#/properties/SpecificCasing",
             "type": "array",