Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated vscode-elements and fixed Private Key storage #2342

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

sebjulliand
Copy link
Collaborator

Changes

This PR bumps vscode-elements to 1.8.0 (and updates the package name from @bendera/vscode-webview-elements to @vscode-elements/elements.

The CustomUI code has been updated according to the changed made since version 0.12.0.

It also fixes an issue that prevented connections private key path from being saved (after saving, the path would be undefined).
image

How to test this PR

Test the private key setting

  1. Edit a connection
  2. Set a private key
  3. Save
  4. Re-open the connection for edition: the private path must be stored correctly and shown in the settings

Check the UI

  • Open the Actions management screen
  • Open the connection settings
  • Open the custom variables editor

Checklist

  • have tested my change

@sebjulliand sebjulliand added the bug A confirmed issue when something isn't working as intended label Nov 12, 2024
@sebjulliand sebjulliand self-assigned this Nov 12, 2024
@worksofliam
Copy link
Contributor

worksofliam commented Nov 12, 2024

@sebjulliand I am not sure what the deal is here, but when I run npm i on this branch it just hangs. If I switch back to master it runs instantly. I'm on a mac.

@sebjulliand
Copy link
Collaborator Author

My bad...I ran npm I at work and it kept work's npm repository URL...I'll fix it asap.

@sebjulliand
Copy link
Collaborator Author

@worksofliam there, fixed. I added a .npmrc file to prevent this from happening to anybody.

@julesyan
Copy link
Collaborator

It no longer saves a new private key properly, after re-picking my private key the connection no longer works. It looks to be setting a fake path to the new private key. I tested this function works properly on the master branch.
I am on a mac if that makes any difference
image

@sebjulliand sebjulliand linked an issue Nov 22, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A confirmed issue when something isn't working as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to connect with SSH certificate
3 participants