Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify IBMi class #2277

Open
wants to merge 37 commits into
base: master
Choose a base branch
from
Open

Simplify IBMi class #2277

wants to merge 37 commits into from
+1,152 −669

Conversation

krethan
Copy link
Contributor

@krethan krethan commented Oct 2, 2024

Changes

Introducing new classes to help simplify logic in IBMiSettings class.

How to test this PR

Examples:

  1. Run the test cases
  2. Expand view A and right click on the node
  3. Run 'Execute Thing' from the command palette

Checklist

  • [* ] have tested my change
  • have created one or more test cases
  • updated relevant documentation
  • Remove any/all console.logs I added
  • [* ] have added myself to the contributors' list in CONTRIBUTING.md

worksofliam and others added 20 commits August 28, 2024 10:49
@worksofliam
Extend the base API to allow other extensions to add their own compon…
c4de790 
…ents.

Signed-off-by: worksofliam <[email protected]>
@worksofliam
Implement custom casting function
3d4a611 
Signed-off-by: worksofliam <[email protected]>
@worksofliam
Remove use of deprecated function
00482be 
Signed-off-by: worksofliam <[email protected]>
@worksofliam
Implement test for ensuring correct lines are returned
178c391 
Signed-off-by: worksofliam <[email protected]>
@sebjulliand
Code cleanup
51e55df 
Signed-off-by: Seb Julliand <[email protected]>
@sebjulliand
Components management refactoring
d440c72 
Signed-off-by: Seb Julliand <[email protected]>
@sebjulliand
Merge branch 'master' into feature/extendable_components
b2123c4
@sebjulliand
Require context to register a component + display components list
5e5e0af 
Signed-off-by: Seb Julliand <[email protected]>
@sebjulliand
Show version of each component
56427ca 
Signed-off-by: Seb Julliand <[email protected]>
@krethan
Seperating logic from IBMi.ts into a new class.
cee0a54
@krethan
Merge branch 'master' of https://github.com/krethan/vscode-ibmi
83938f5
@krethan
Fixed few issues introduced with IBMiSettings
9564ffc 
class.
@krethan
Removed unneccessary comments
9f6a355
@sebjulliand
Merge branch 'master' into feature/extendable_components
a7d5f14
@sebjulliand
Fixed wrong import
226d0ce 
Signed-off-by: Seb Julliand <[email protected]>
@sebjulliand
Always show "Download client certificate" button
34fda10 
Especially when there is a problem...

Signed-off-by: Seb Julliand <[email protected]>
@worksofliam
Use type for component state instead of enum
f79e370 
Signed-off-by: worksofliam <[email protected]>
@worksofliam
Merge pull request codefori#2281 from codefori/fix/localDebugCertDown…
afc71a2 
…load

Always show "Download client certificate" button
@worksofliam
Merge pull request codefori#2232 from codefori/feature/extendable_com…
2d65d6a 
…ponents

Extend the base API to allow other extensions to add their own components.
@worksofliam
Merge branch 'master' into fix/bad_lines_from_member
2061409
worksofliam
worksofliam requested changes Oct 7, 2024
View reviewed changes
Copy link
Contributor

@worksofliam worksofliam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some general comments. Also, we typically use an indent of 2 instead of 4. Looks good so far!

src/api/IBMiSettings.ts Outdated Show resolved Hide resolved
src/api/IBMiApps.ts Outdated Show resolved Hide resolved
src/api/IBMiSettings.ts Outdated Show resolved Hide resolved
src/api/IBMiSettings.ts Outdated Show resolved Hide resolved
sebjulliand and others added 9 commits October 7, 2024 21:57
@sebjulliand
Discover IBM i Java installation
41609be 
Signed-off-by: Seb Julliand <[email protected]>
@sebjulliand
Use IBMi remote Java feature for debug service
d23ff7d 
Signed-off-by: Seb Julliand <[email protected]>
@sebjulliand
Fix debug java test
d3a5e50 
Signed-off-by: Seb Julliand <[email protected]>
@sebjulliand @worksofliam
Do not use interpolation when not needed
449783f 
Co-authored-by: LJ <[email protected]>
@worksofliam
Merge pull request codefori#2245 from codefori/fix/bad_lines_from_member
c4e8a15 
Fix/bad_lines_from_member
@sebjulliand
Merge pull request codefori#2283 from codefori/feature/discoverjdk
7fefd51 
Made Java installation as connection features
@worksofliam
Bump to 2.13.1
32e4566 
Signed-off-by: worksofliam <[email protected]>
@worksofliam
Fix type issue in Search
f7da821 
Signed-off-by: worksofliam <[email protected]>
@worksofliam
Bump to 2.13.2
fea455d 
Signed-off-by: worksofliam <[email protected]>
@krethan
Copy link
Contributor Author

krethan commented Oct 13, 2024

Okay sending for another review.

@worksofliam worksofliam self-requested a review October 14, 2024 13:52
@worksofliam
Copy link
Contributor

@krethan I should give a warning that there is another PR being worked on which separates the UI logic from the backend logic in the IBM i class. That may have to come before this.

@krethan
Copy link
Contributor Author

krethan commented Oct 24, 2024

Thanks for the heads up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worksofliam worksofliam Awaiting requested review from worksofliam

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@krethan @worksofliam @sebjulliand