Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GeoJSON is missing from production build #60

Closed
carpeliam opened this issue Oct 21, 2016 · 6 comments
Closed

GeoJSON is missing from production build #60

carpeliam opened this issue Oct 21, 2016 · 6 comments
Labels

Comments

@carpeliam
Copy link
Member

Steps to reproduce:

  1. Create production build (npm run build)
  2. Open website (e.g., cd dist && python -m SimpleHTTPServer)
  3. Perform some kind of action that uses GeoJSON, for example, find an election day polling location
  4. Verify that a JavaScript error occurs

I've narrowed it down to GeoJSON by modifying the uglify config in Grunt:

grunt.initConfig({
  uglify: {
    options: {
      mangle: false,
      compress: false
    }
  }
  /* ... */
});
@moczka
Copy link
Member

moczka commented Oct 21, 2016

Yeah I get this error.
screen shot 2016-10-21 at 2 39 44 pm

@moczka
Copy link
Member

moczka commented Oct 21, 2016

Without the uglify settings of course I get this.
screen shot 2016-10-21 at 2 44 27 pm

@moczka
Copy link
Member

moczka commented Oct 21, 2016

Scrapping GeoJSON for early polling will be easy but for the election day not so much. I'll search around and read to see if there is a viable solution to #40

@carpeliam
Copy link
Member Author

@moczka sounds awesome! I'm going to assign #40 to you then - feel free to unassign it if you put it back down.

@moczka
Copy link
Member

moczka commented Oct 22, 2016

@carpeliam Great thanks. I wouldn't mind if someone could tag along to fix #40 with me in case I can't find anything. I will try my best, keep everyone up to date on my findings.

@moczka
Copy link
Member

moczka commented Nov 1, 2016

GeoJson is no longer a dependency. Closing issue

@moczka moczka closed this as completed Nov 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants