Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consider retiring geojson-google-maps #40

Open
thecristen opened this issue Sep 17, 2016 · 2 comments
Open

consider retiring geojson-google-maps #40

thecristen opened this issue Sep 17, 2016 · 2 comments
Assignees

Comments

@thecristen
Copy link
Member

As noted on that repo, Google Maps API now supports GeoJSON.

@carpeliam
Copy link
Member

I looked into this a little bit, due to #60. It seems like the way to do this is to create a new google.maps.Data object, and add GeoJSON data to that. Unfortunately, that returns a google.maps.data.Polygon object, which isn't the same as a google.maps.Polygon object (which is super annoying, Google, seriously). Google's functionality to detect if a point is within a polygon works with a google.maps.Polygon, not a google.maps.data.Polygon, and while some people have been able to write code to translate, this seems super sketchy and brittle. Meh. :/ Maybe there's another way?

@moczka
Copy link
Member

moczka commented Oct 24, 2016

@carpeliam is file maps.google.polygon.containsLatLng.js extension in folder /vendor meant to be used to possibly fix this issue? If so, should I start implementing this extension on all the modules that use GeoJson to finally remove our dependency on it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants