-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix HTTPS mixed content warnings/blocking for codeforamerica.org #912
base: master
Are you sure you want to change the base?
Conversation
It might be easier to look at individual commits here than the whole |
This is huge, thank you for your incredible effort. I don’t actually want to migrate to SSL, I just want to make sure the issue finder works with SSL so it’s compatible with you guys. In particular, I'd prefer for things to remain protocol-relative where possible, and to wait on updating links until we can move to a new certificate that’s compatible with both the apex and subdomain URLs. Is it possible to break this down a bit? |
It's definitely possible to break this down, and re-submit with some cherry-picked commits. But I really suggest merging this as-is, because nothing here breaks the site when loaded under The Google CDN and cdnjs have both changed their recommended URLs from protocol-relative to I didn't go through and update all |
Okay. It’s a bit much for me to evaluate, maybe I can conscript @davidrleonard to give this a more in-depth look. |
Interested in bumping this. I created an account on forum.codeforamerica.org and noticed the connection wasn't HTTPS. I get sweaty when I put in a password over an unsecured website. |
This PR doesn't fix forum.codeforamerica.org, but you're right to feel sweaty - you should never be asked to put in a password over an insecure connection. |
I'm happy to fix the merge conflicts that have developed in this branch, once I have a 👍 that it's slated for revision/merging. |
Related: Mozilla this morning joined the Chrome team in their intent to deprecate HTTP. The post includes a good recap of the rationale: https://groups.google.com/forum/#!topic/mozilla.dev.platform/xaGffxAM-hs |
Any status update available for this issue? |
This does a huge once-over on the codeforamerica.org repo.
Broadly:
http://codeforamerica.org
->https://www.codeforamerica.org
https://
<form>
tags pointed to secure endpointsThere were something like 20 images that had no secure alternative, visible by running
grep -r "src=\"http:" *
in the project root. Many of them are actually 404s now anyway. For the ones that remain, the right solution is to download them and inline them into the repo, to be served fromhttps://www.codeforamerica.org
.This doesn't cover
/blog/
or/library/
, which apparently are handled somewhere else, not in GitHub? If you open source it, I'll finish the job. :)In any case, once merged, the rest of codeforamerica.org should be basically ready for an all-HTTPS future.