Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add macOS ARM64 wheel build #580

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

pb-dod
Copy link

@pb-dod pb-dod commented Dec 18, 2024

Fixes: #409

Adds macOS ARM64 wheel build while maintaining x86_64 wheel support. This helps address installation issues on Apple Silicon Macs where users currently need to build from source, which can be problematic due to C++ compiler requirements (see #409).

Changes

  • Added bdist_wheel command with macosx-12.6-arm64 platform tag
  • Maintained existing macosx-12.6-x86_64 wheel for Intel Mac support

Why

Currently, users on Apple Silicon Macs may need to build from source, which requires specific Xcode Command Line Tools versions and C++ compiler configurations. By providing pre-built wheels for both architectures, we can:

  1. Reduce installation friction for users on both Intel and Apple Silicon Macs
  2. Avoid compiler-related issues described in Missing C++ Standard Library Headers When Building Wheels On Mac #409
  3. Ensure proper compilation of C++ extensions for each architecture

Testing Help Needed

@thomasrockhu-codecov Could you help test this change? We need to verify:

  • ARM64 wheel builds successfully
  • Installation works on both M1/M2 and Intel Macs

Copy link

codecov bot commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.66%. Comparing base (b7033a9) to head (98920f7).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #580      +/-   ##
==========================================
- Coverage   95.67%   95.66%   -0.01%     
==========================================
  Files          86       83       -3     
  Lines        3120     3117       -3     
==========================================
- Hits         2985     2982       -3     
  Misses        135      135              
Flag Coverage Δ
python3.10 ?
python3.11 ?
python3.12 95.92% <ø> (ø)
python3.8 ?
python3.9 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing C++ Standard Library Headers When Building Wheels On Mac
1 participant