Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make default search case insensitive #568

Closed
wants to merge 3 commits into from

Conversation

joseph-sentry
Copy link
Contributor

when looking for files in the default patterns search, it's better to
be flexible and not care about case sensitive matching. For example,
certain frameworks output their test results with the word "test" in
all upper case and we shouldn't need to specify both "test" and "TEST"
to match those files.

when looking for files in the default patterns search, it's better to
be flexible and not care about case sensitive matching. For example,
certain frameworks output their test results with the word "test" in
all upper case and we shouldn't need to specify both "test" and "TEST"
to match those files.
i think this is meant to be remapIstanbul since that's the name of a
JS coverage tool
@joseph-sentry joseph-sentry requested a review from a team November 28, 2024 14:54
Copy link

codecov bot commented Nov 28, 2024

❌ 5 Tests Failed:

Tests completed Failed Passed Skipped
3550 5 3545 0
View the top 3 failed tests by shortest run time
api.temp.calculator.test_calculator::test_divide
Stack Traces | 0.001s run time
def
                test_divide():
                > assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = <function Calculator.divide at 0x104c9eb90>(1, 2)
                E + where <function Calculator.divide at 0x104c9eb90> = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError
api.temp.calculator.test_calculator::test_divide
Stack Traces | 0.001s run time
def
                test_divide():
                > assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = <function Calculator.divide at 0x104c9eb90>(1, 2)
                E + where <function Calculator.divide at 0x104c9eb90> = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError
api.temp.calculator.test_calculator::test_divide
Stack Traces | 0.001s run time
def
                test_divide():
                > assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = <function Calculator.divide at 0x104c9eb90>(1, 2)
                E + where <function Calculator.divide at 0x104c9eb90> = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

Copy link

✅ All tests successful. No failed tests were found.

📣 Thoughts on this report? Let Codecov know! | Powered by Codecov

Swatinem
Swatinem previously approved these changes Nov 28, 2024
@@ -100,4 +102,8 @@ def globs_to_regex(patterns: List[str]) -> Optional[Pattern]:
return None

regex_str = ["(" + translate(pattern) + ")" for pattern in patterns]
return re.compile("|".join(regex_str))
# return re.compile("|".join(regex_str))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# return re.compile("|".join(regex_str))

@thomasrockhu
Copy link

I don't think this should go in, it will change user behavior for search and I expect it will have unexpected consequences. I'd rather users have to be explicit about the files they want then not be able to not include it

@joseph-sentry
Copy link
Contributor Author

good point, i will close

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants