-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: make default search case insensitive #568
Conversation
when looking for files in the default patterns search, it's better to be flexible and not care about case sensitive matching. For example, certain frameworks output their test results with the word "test" in all upper case and we shouldn't need to specify both "test" and "TEST" to match those files.
❌ 5 Tests Failed:
View the top 3 failed tests by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
✅ All tests successful. No failed tests were found. 📣 Thoughts on this report? Let Codecov know! | Powered by Codecov |
@@ -100,4 +102,8 @@ def globs_to_regex(patterns: List[str]) -> Optional[Pattern]: | |||
return None | |||
|
|||
regex_str = ["(" + translate(pattern) + ")" for pattern in patterns] | |||
return re.compile("|".join(regex_str)) | |||
# return re.compile("|".join(regex_str)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# return re.compile("|".join(regex_str)) |
I don't think this should go in, it will change user behavior for search and I expect it will have unexpected consequences. I'd rather users have to be explicit about the files they want then not be able to not include it |
good point, i will close |
when looking for files in the default patterns search, it's better to
be flexible and not care about case sensitive matching. For example,
certain frameworks output their test results with the word "test" in
all upper case and we shouldn't need to specify both "test" and "TEST"
to match those files.