chore: improve label analysis log if failed to calculate #307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If Codecov fails to calculate label analysis (with an actual error), the log line is borderline unusable, because it cointains too much text. So these changes restrict the amount of info shown to include: `head_commit`, `base_commit` and `external_id`. This info should allow users to quickly check if the comparison is between the commits they expect, and give them useful info to pass to the support team, so we can learn what happened. Unfortunatelly at this points the errors are also useless. THey only state "failed to calculate".
giovanni-guidini
force-pushed
the
gio/improve-ats-log-on-failure
branch
from
3073fb3 to
496d2e5
Compare
Codecov Report
@@ Coverage Diff @@
## main #307 +/- ##
=======================================
Coverage 95.52% 95.52%
=======================================
Files 79 79
Lines 2726 2726
=======================================
Hits 2604 2604
Misses 122 122
Flags with carried forward coverage won't be shown. Click here to find out more.
|
scott-codecov
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If Codecov fails to calculate label analysis (with an actual error),
the log line is borderline unusable, because it cointains too much text.
So these changes restrict the amount of info shown to include:
head_commit,base_commitandexternal_id. This info should allowusers to quickly check if the comparison is between the commits they expect,
and give them useful info to pass to the support team, so we can learn what happened.
Unfortunatelly at this points the errors are also useless. THey only state
"failed to calculate".