chore: Remove requirement for pytest #273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pytest was required only by the `PythonStandardRunner`, and only in the `strict_mode`. No one uses that. At first it was develop because we were concerned that users would be picky by us running pytest with `subprocess.run`, so `strict_mode` was an alternative. Since then people are starting to use ATS and that hasn't been an issue. Plus with custom runners we can solve this problem without the complications of requiring pytest. And there's a possibility (although I think it's very unlikely) that importing pytest from the CLI might cause some of the issues we were seeing when running tests from it in ATS. Who knows. In any case, removing pytest and all code associated with it.
giovanni-guidini
force-pushed
the
gio/remove-pytest-requirement
branch
from
c0b48b7 to
d8b0850
Compare
Codecov Report
@@ Coverage Diff @@
## master #273 +/- ##
==========================================
- Coverage 94.91% 94.86% -0.05%
==========================================
Files 78 78
Lines 2694 2631 -63
==========================================
- Hits 2557 2496 -61
+ Misses 137 135 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
giovanni-guidini
requested review from
dana-yaish,
scott-codecov,
joseph-sentry and
matt-codecov
joseph-sentry
previously approved these changes
Oct 4, 2023
joseph-sentry
approved these changes
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pytest was required only by the
PythonStandardRunner, and only in thestrict_mode.No one uses that.
At first it was develop because we were concerned that users would be picky by us running pytest with
subprocess.run,so
strict_modewas an alternative. Since then people are starting to use ATS and that hasn't been an issue.Plus with custom runners we can solve this problem without the complications of requiring pytest.
And there's a possibility (although I think it's very unlikely) that importing pytest from the CLI
might cause some of the issues we were seeing when running tests from it in ATS. Who knows.
In any case, removing pytest and all code associated with it.