Change path_fixes to report_fixes

[joseph-sentry]

Fixes: #207

Depends on: codecov/worker#58

[dana-yaish]

can you elaborate more on why we're doing this? I can see that worker is expecting path_fixes to be in the stored report
https://github.com/codecov/worker/blob/main/services/report/parser/version_one.py#L27

[joseph-sentry]

Hm, it looks like the renaming will have to happen in the worker as well. @drazisil-codecov pointed out that what is happening in _get_file_fixers is not path fixing, it's report fixing

[dana-yaish]

but I can see that the legacy way to get and build path fixes in worker is the same in the CLI, is this a matter of naming only?

[joseph-sentry]

but I can see that the legacy way to get and build path fixes in worker is the same in the CLI, is this a matter of naming only?

Yes, for the most part I think this is a naming issue, and it seems to exist in the uploader/legacy version as well

I am curious to know if we should be using this:
https://github.com/codecov/worker/blob/main/services/path_fixer/fixpaths.py#L8
in the processing of a V1 report because I think it's only being used in the processing of a legacy report and I'm not sure whether it's actually necessary for a V1 report. I think this line is part of default path fixing

[joseph-sentry]

This shouldn't be a breaking change because the worker now handles the field being named "path_fixes" and "report_fixes" in codecov/worker#58, which this PR depends on.

[thomasrockhu-codecov]

@joseph-sentry is there any update on this?

[joseph-sentry]

@joseph-sentry is there any update on this?

This is ready for another review

[codecov]

Codecov Report

Merging #224 (5726dc4) into main (73f09c4) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #224   +/-   ##
=======================================
  Coverage   95.55%   95.55%           
=======================================
  Files          79       79           
  Lines        2745     2745           
=======================================
  Hits         2623     2623           
  Misses        122      122           

Flag	Coverage Δ
python3.10	95.67% <ø> (ø)
python3.11	95.66% <ø> (ø)
python3.8	95.67% <ø> (ø)
python3.9	95.67% <ø> (ø)
smart-labels	95.55% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
codecov_cli/services/upload/upload_sender.py	100.00% <ø> (ø)

[thomasrockhu-codecov]

@joseph-sentry any movement here?