Skip to content

Commit

Permalink
chore: remove smart-open
Browse files Browse the repository at this point in the history
We want to add codecov-cli to getsentry/pypi.
It was asked that we drop the smart-open dependency.

I went back and checked that smart-open is really used for dealing with
files in remote storage and decompressing things under-the-hood.
We don't need any of that, and are well served by the default open function.

So it's fine to drop it.
  • Loading branch information
giovanni-guidini committed Nov 6, 2023
1 parent 4676151 commit d458db1
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 5 deletions.
1 change: 0 additions & 1 deletion codecov_cli/plugins/compress_pycoverage_contexts.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
from typing import Any, List

import ijson
from smart_open import open

from codecov_cli.plugins.types import PreparationPluginReturn

Expand Down
6 changes: 3 additions & 3 deletions requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -37,9 +37,9 @@ requests==2.31.0
responses==0.21.0
# via codecov-cli (setup.py)
rfc3986[idna2008]==1.5.0
# via httpx
smart-open==6.4.0
# via codecov-cli (setup.py)
# via
# httpx
# rfc3986
sniffio==1.3.0
# via
# anyio
Expand Down
1 change: 0 additions & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@
"ijson==3.*",
"pyyaml==6.*",
"responses==0.21.*",
"smart-open==6.*",
"tree-sitter==0.20.*",
],
entry_points={
Expand Down

0 comments on commit d458db1

Please sign in to comment.