Skip to content

Commit

Permalink
fix: typing and tests
Browse files Browse the repository at this point in the history
  • Loading branch information
joseph-sentry committed Nov 5, 2024
1 parent 88d233e commit 1b866d8
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
3 changes: 2 additions & 1 deletion codecov_cli/services/report/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
request_result,
send_post_request,
)
from typing import Union

logger = logging.getLogger("codecovcli")
MAX_NUMBER_TRIES = 3
Expand Down Expand Up @@ -73,7 +74,7 @@ def create_report_results_logic(
token: str,
enterprise_url: str,
fail_on_error: bool = False,
args: dict | None = None,
args: Union[dict, None] = None,
):
encoded_slug = encode_slug(slug)
sending_result = send_reports_result_request(
Expand Down
2 changes: 2 additions & 0 deletions tests/services/report/test_report_results.py
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ def test_report_results_command_with_warnings(mocker):

assert res == mock_send_reports_result_request.return_value
mock_send_reports_result_request.assert_called_with(
args=None,
commit_sha="commit_sha",
report_code="code",
service="service",
Expand Down Expand Up @@ -85,6 +86,7 @@ def test_report_results_command_with_error(mocker):
]
assert res == mock_send_reports_result_request.return_value
mock_send_reports_result_request.assert_called_with(
args=None,
commit_sha="commit_sha",
report_code="code",
service="service",
Expand Down

0 comments on commit 1b866d8

Please sign in to comment.