chore: fail on error by default #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Until know the '--fail-on-error' option for `create-commit` and `create-report` commands was dependent on a `INPUTS_FAIL_ON_ERROR`. However `INPUTS_FAIL_ON_ERROR` is not a valid input (see `action.yml`). Plus, it's not smart to NOT activate this feature, because ATS needs all these commands to succeed to actually work. So the present changes activate '--fail-on-error' by default for `create-commit` and `create-report` commands.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #34 +/- ##
==========================================
- Coverage 47.48% 47.44% -0.05%
==========================================
Files 7 7
Lines 219 215 -4
==========================================
- Hits 104 102 -2
+ Misses 115 113 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
thomasrockhu-codecov
approved these changes
Jan 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until know the '--fail-on-error' option for
create-commitandcreate-reportcommands was dependent on aINPUTS_FAIL_ON_ERROR.However
INPUTS_FAIL_ON_ERRORis not a valid input (seeaction.yml).Plus, it's not smart to NOT activate this feature, because ATS needs
all these commands to succeed to actually work.
So the present changes activate '--fail-on-error' by default for
create-commitandcreate-reportcommands.