chore: fail on error by default

Until know the '--fail-on-error' option for `create-commit` and
`create-report` commands was dependent on a `INPUTS_FAIL_ON_ERROR`.

However `INPUTS_FAIL_ON_ERROR` is not a valid input (see `action.yml`).
Plus, it's not smart to NOT activate this feature, because ATS needs
all these commands to succeed to actually work.

So the present changes activate '--fail-on-error' by default for
`create-commit` and `create-report` commands.

dist/codecov_ats.sh

@@ -46,17 +46,15 @@ codecovcli_args=""
 # Install Codecov CLI
 pip install codecov-cli
 
-create_commit_args=""
-[[ -n $INPUTS_FAIL_ON_ERROR ]] && create_commit_args+="-Z "
+create_commit_args="--fail-on-error "
 [[ -n $INPUTS_OVERRIDE_PARENT ]] && create_commit_args+="--parent-sha ${INPUTS_OVERRIDE_PARENT} "
 [[ -n $INPUTS_OVERRIDE_PR ]] && create_commit_args+="-P ${INPUTS_OVERRIDE_PR} "
 [[ -n $INPUTS_OVERRIDE_BRANCH ]] && create_commit_args+="-B ${INPUTS_OVERRIDE_BRANCH} "
 [[ -n $INPUTS_OVERRIDE_COMMIT ]] && create_commit_args+="-C ${INPUTS_OVERRIDE_COMMIT} "
 [[ -n $INPUTS_OVERRIDE_SLUG ]] && create_commit_args+="-r ${INPUTS_OVERRIDE_SLUG} "
 
 # create-report
-create_report_args=""
-[[ -n $INPUTS_FAIL_ON_ERROR ]] && create_report_args+="-Z "
+create_report_args="--fail-on-error "
 [[ -n $INPUTS_OVERRIDE_COMMIT ]] && create_report_args+="-C ${INPUTS_OVERRIDE_COMMIT} "
 [[ -n $INPUTS_OVERRIDE_SLUG ]] && create_report_args+="-r ${INPUTS_OVERRIDE_SLUG} "
 

src/codecov_ats.sh

@@ -46,17 +46,15 @@ codecovcli_args=""
 # Install Codecov CLI
 pip install codecov-cli
 
-create_commit_args=""
-[[ -n $INPUTS_FAIL_ON_ERROR ]] && create_commit_args+="-Z "
+create_commit_args="--fail-on-error "
 [[ -n $INPUTS_OVERRIDE_PARENT ]] && create_commit_args+="--parent-sha ${INPUTS_OVERRIDE_PARENT} "
 [[ -n $INPUTS_OVERRIDE_PR ]] && create_commit_args+="-P ${INPUTS_OVERRIDE_PR} "
 [[ -n $INPUTS_OVERRIDE_BRANCH ]] && create_commit_args+="-B ${INPUTS_OVERRIDE_BRANCH} "
 [[ -n $INPUTS_OVERRIDE_COMMIT ]] && create_commit_args+="-C ${INPUTS_OVERRIDE_COMMIT} "
 [[ -n $INPUTS_OVERRIDE_SLUG ]] && create_commit_args+="-r ${INPUTS_OVERRIDE_SLUG} "
 
 # create-report
-create_report_args=""
-[[ -n $INPUTS_FAIL_ON_ERROR ]] && create_report_args+="-Z "
+create_report_args="--fail-on-error "
 [[ -n $INPUTS_OVERRIDE_COMMIT ]] && create_report_args+="-C ${INPUTS_OVERRIDE_COMMIT} "
 [[ -n $INPUTS_OVERRIDE_SLUG ]] && create_report_args+="-r ${INPUTS_OVERRIDE_SLUG} "