Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skills Page/Tab update. #116

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Skills Page/Tab update. #116

wants to merge 5 commits into from

Conversation

kyperbelt
Copy link

@kyperbelt kyperbelt commented Jul 28, 2024

Changes in this PR

  • Removed unnecessary dangling body tags from header/footer.
  • Moved header and footer includes into the body in the layout templates. They were previously located outside the body tag, which might explain why they needed those dangling body tags. HTML spec for more info on how to use header tags.
  • Separated the end of file scripts from the footer and placed them in their own 'end.html' include file.
  • Added the navigation header include file to the skills page/tab so that it overlays on top of the one in the iframe. I also moved the iframe 10px up so that its fully concealed by the main header. This is a quick-fix so that the logo link stops redirecting to the wrong home page from the skills tab.

Description of Problem

While browsing the live site codeforsacramento.org, I noticed that if you click on the "I Have Skills" button, it takes you to a new page with a different nav bar layout.
Home Page:

image

Skills Tab:

image

Clicking on the leftmost icon to take you home, takes you to a homepage that looks the same, but clicking on the "I have Skills" button again leads to a page not found.

image

Solution

To "Fix" this I added the header to the skills layout on top of the header from the iframe. This is only a temporary fix until (I assume) the skills form is ported over to the new site.

Testing

  • Tested that the home logo link now takes you to the appropriate landing site and not the codeforsacramento.nationbuilder.com home page.

  • Tested that the functionality remained similar for other pages on multiple screen device sizes.

Important

I am almost 100% sure that everything works the same, but just in case, someone should take a look and make sure that the functionality of the site remains the same.

@kyperbelt kyperbelt marked this pull request as ready for review July 28, 2024 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant