Refactor/detail/add review #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
seohyun319
commented
Dec 18, 2022
•
seohyun319
commented
- refactor Detail - review
- make reviewInput, reviewList
- set rate star view using mui
- [FEAT] Refactor detail page #8
…conut-thisABLE/thisABLE_front_2 into refactor/detail/add-review
nami-koko
requested changes
Dec 20, 2022
components/detail/ReviewInput.tsx
Outdated
| import Rating from '@mui/material/Rating' | ||
|
|
||
| const ReviewInput = () => { | ||
| const [userType, setUserType] = useState('anonymous') |
There was a problem hiding this comment.
state들 다 타입 지정(inputValue - string 등)하는게 좋을거같고 userType이나 Sort는 enum으로 타입 처리 하면 좋을거같아요!
nami-koko
approved these changes
Dec 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.