Add custom init containers user can add #424
Conversation
prafull01
force-pushed
the
add-init-containers
branch
2 times, most recently
from
ee7e336 to
bcebac2
Compare
| @@ -339,6 +347,9 @@ spec: | |||
| {{- else }} | |||
| emptyDir: {} | |||
| {{- end }} | |||
| {{ with .Values.statefulset.volumes }} | |||
There was a problem hiding this comment.
Would it make more sense to have a different top-level value for volume mounts inside the statefulset? I can imagine that users might want to add a volume not used in an initContainer, wdyt? With the current setup a user could only ever define volumes that are also used in an init container.
There was a problem hiding this comment.
I have added the test cases for all the scenarios as well
There was a problem hiding this comment.
Okay. Got it. You want to move the volumeMounts outside. Done.
There was a problem hiding this comment.
Do you think it's ok for all init containers to mount all extra dirs? I guess there is no harm
There was a problem hiding this comment.
Yes, I think it is ok. we don't want to over complicate things.
build/templates/values.yaml
Outdated
| # - "sh" | ||
| # - "-c" | ||
| # - "curl -s -H \"Metadata:true\" --noproxy \"*\" \"http://169.254.169.254/metadata/instance?api-version=2021-02-01\" | jq '.' > /metadata/instance_metadata.json" | ||
| # volumeMounts: |
There was a problem hiding this comment.
I would add a comment here that volume mounts are reused in the main crdb container again.
| @@ -263,6 +266,11 @@ spec: | |||
| {{- end }} | |||
| protocol: TCP | |||
| volumeMounts: | |||
| {{ range .Values.statefulset.initContainers }} | |||
There was a problem hiding this comment.
/nit but I would add this stanza to the bottom of the volumeMounts section just so we don't obscure the datadir and certs
prafull01
force-pushed
the
add-init-containers
branch
2 times, most recently
from
f7e0e14 to
86822f7
Compare
prafull01
force-pushed
the
add-init-containers
branch
3 times, most recently
from
85ed46c to
e5189f8
Compare
prafull01
force-pushed
the
add-init-containers
branch
from
e5189f8 to
423ee65
Compare
| @@ -339,6 +347,9 @@ spec: | |||
| {{- else }} | |||
| emptyDir: {} | |||
| {{- end }} | |||
| {{ with .Values.statefulset.volumes }} | |||
There was a problem hiding this comment.
Do you think it's ok for all init containers to mount all extra dirs? I guess there is no harm
Fixes #422