Adding ability to define a custom startup probe

cockroachdb · Sep 23, 2024 · c7f3e79 · c7f3e79
1 parent 950a699
commit c7f3e79
Show file tree

Hide file tree

Showing 5 changed files with 26 additions and 0 deletions.
diff --git a/build/templates/README.md b/build/templates/README.md
@@ -343,6 +343,7 @@ For details see the [`values.yaml`](values.yaml) file.
 | `statefulset.resources`                                   | Resource requests and limits for StatefulSet Pods               | `{}`                                                  |
 | `statefulset.customLivenessProbe`                         | Custom Liveness probe                                           | `{}`                                             |
 | `statefulset.customReadinessProbe`                        | Custom Rediness probe                                           | `{}`                                             |
+| `statefulset.customStartupProbe`                          | Custom Startup probe                                            | `{}`                                             |
 | `statefulset.terminationGracePeriodSeconds`               | Termination grace period for CRDB statefulset pods              | `300`                                                 |
 | `service.ports.grpc.external.port`                        | CockroachDB primary serving port in Services                    | `26257`                                               |
 | `service.ports.grpc.external.name`                        | CockroachDB primary serving port name in Services               | `grpc`                                                |

diff --git a/build/templates/values.yaml b/build/templates/values.yaml
@@ -269,6 +269,16 @@ statefulset:
     #   scheme: HTTPS
     # initialDelaySeconds: 30
     # periodSeconds: 5
+
+  # Custom Startup Probe
+  # https://kubernetes.io/docs/tasks/configure-pod-container/configure-liveness-readiness-startup-probes/#define-startup-probes
+  customStartupProbe: {}
+    # httpGet:
+    #   path: /health
+    #   port: http
+    #   scheme: HTTPS
+    # initialDelaySeconds: 30
+    # periodSeconds: 5
 
   securityContext:
     enabled: true

diff --git a/cockroachdb/README.md b/cockroachdb/README.md
@@ -344,6 +344,7 @@ For details see the [`values.yaml`](values.yaml) file.
 | `statefulset.resources`                                   | Resource requests and limits for StatefulSet Pods               | `{}`                                                  |
 | `statefulset.customLivenessProbe`                         | Custom Liveness probe                                           | `{}`                                             |
 | `statefulset.customReadinessProbe`                        | Custom Rediness probe                                           | `{}`                                             |
+| `statefulset.customStartupProbe`                          | Custom Startup probe                                            | `{}`                                             |
 | `statefulset.terminationGracePeriodSeconds`               | Termination grace period for CRDB statefulset pods              | `300`                                                 |
 | `service.ports.grpc.external.port`                        | CockroachDB primary serving port in Services                    | `26257`                                               |
 | `service.ports.grpc.external.name`                        | CockroachDB primary serving port name in Services               | `grpc`                                                |

diff --git a/cockroachdb/templates/statefulset.yaml b/cockroachdb/templates/statefulset.yaml
@@ -267,6 +267,10 @@ spec:
               mountPath: /cockroach/log-config
               readOnly: true
           {{- end }}
+          {{- if .Values.statefulset.customStartupProbe }}
+          startupProbe:
+            {{ toYaml .Values.statefulset.customStartupProbe | nindent 12 }}
+          {{- end }}
           livenessProbe:
           {{- if .Values.statefulset.customLivenessProbe }}
             {{ toYaml .Values.statefulset.customLivenessProbe | nindent 12 }}

diff --git a/cockroachdb/values.yaml b/cockroachdb/values.yaml
@@ -270,6 +270,16 @@ statefulset:
     #   scheme: HTTPS
     # initialDelaySeconds: 30
     # periodSeconds: 5
+
+  # Custom Startup Probe
+  # https://kubernetes.io/docs/tasks/configure-pod-container/configure-liveness-readiness-startup-probes/#define-startup-probes
+  customStartupProbe: {}
+    # httpGet:
+    #   path: /health
+    #   port: http
+    #   scheme: HTTPS
+    # initialDelaySeconds: 30
+    # periodSeconds: 5
 
   securityContext:
     enabled: true