test: Drop push/pull ID preservation assumption #1477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid general Fedora updates. We want to cover the latter during image refreshes. This decouples the COPR changes from Fedora changes, makes the test more reproducible, and also faster.
Interleaving the user and system tests in that way is really weird, and almost surely a copy&paste bug.
Until very recently, a cycle of `podman push`/`pull` preserved an image's ID. Starting with containers-common 1-98 this is not the case any more, as that changed the on-disk compression format. Quoting podman devs: "The digests validate a specific image _representation_, not some abstract "sameness" of an image." Instead, remove the original busybox image for the user as well (that already happend for the system user), and more explicitly check deletion of an image with multiple tags. Fixes containers/podman#20611 Obsoletes cockpit-project/bots#5515
jelly
approved these changes
Nov 7, 2023
|
LGTM |
martinpitt
added a commit
to martinpitt/bots
that referenced
this pull request
Nov 7, 2023
…sion" This was handled more properly in cockpit-project/cockpit-podman#1477 This reverts commit 6424332. Fixes cockpit-project#5515
martinpitt
added a commit
to cockpit-project/bots
that referenced
this pull request
Nov 7, 2023
…sion" This was handled more properly in cockpit-project/cockpit-podman#1477 This reverts commit 6424332. Fixes #5515
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until very recently, a cycle of
podman push/pullpreserved animage's ID. Starting with containers-common 1-98 this is not the case
any more, as that changed the on-disk compression format. Quoting podman
devs: "The digests validate a specific image representation, not some
abstract "sameness" of an image."
Instead, remove the original busybox image for the user as well (that
already happend for the system user), and more explicitly check deletion
of an image with multiple tags.
Fixes containers/podman#20611
Obsoletes cockpit-project/bots#5515