Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile: Update Cockpit lib to 5ac51ecd0d5c4739d0478bee88efb8fb #1458

Merged
merged 1 commit into from
Oct 19, 2023

Conversation

github-actions[bot]
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the bot label Oct 19, 2023
@github-actions github-actions bot changed the title [no-test] Makefile: Update Cockpit lib to 5ac51ecd0d5c4739d0478bee88efb8fb Makefile: Update Cockpit lib to 5ac51ecd0d5c4739d0478bee88efb8fb Oct 19, 2023
@martinpitt martinpitt force-pushed the cockpit-lib-update-cockpit-lib-20231019-021856 branch from e8efa2f to 2ef9a74 Compare October 19, 2023 02:19
@martinpitt
Copy link
Member

These error messages look legit, and need to be allowed explicitly.

jelly pushed a commit that referenced this pull request Oct 19, 2023
This new lib update now errors out on unexpected console.error messages,
these are harmless in podman and need to be allowed.

Closes #1458
@jelly jelly force-pushed the cockpit-lib-update-cockpit-lib-20231019-021856 branch from 2ef9a74 to c66370c Compare October 19, 2023 08:29
jelly pushed a commit that referenced this pull request Oct 19, 2023
This new lib update now errors out on unexpected console.error messages,
these are harmless in podman and need to be allowed.

Closes #1458
@jelly jelly force-pushed the cockpit-lib-update-cockpit-lib-20231019-021856 branch from c66370c to a9ebd0e Compare October 19, 2023 08:37
This new lib update now errors out on unexpected console.error messages,
these are harmless in podman and need to be allowed.

Closes #1458
@jelly jelly force-pushed the cockpit-lib-update-cockpit-lib-20231019-021856 branch from a9ebd0e to 90454d2 Compare October 19, 2023 09:08
@jelly jelly requested a review from martinpitt October 19, 2023 10:38
@jelly jelly removed the needswork label Oct 19, 2023
Copy link
Member

@martinpitt martinpitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@martinpitt martinpitt merged commit 5bd629c into main Oct 19, 2023
20 checks passed
@martinpitt martinpitt deleted the cockpit-lib-update-cockpit-lib-20231019-021856 branch October 19, 2023 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants