-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix:issue#1216 allow the search filters to be cleared or reset to the default #1292
base: main
Are you sure you want to change the base?
Conversation
I figured out how we can use deprecated |
Either of the two works for now. Tending towards the deprecated one, so that we can move all Selects at once to the new. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am happy with the search input adoption - but totally disagree with adopting the typeahead for the system/user filter. Logs page uses the typeahead in a case where there are hunderds of select options, not 3 like here.
I know it's suggested in #1216 (comment) but it's just not correct design wise..
Please undo the select part, and keep the SearchInput. Let's also add a test for the new functionality and it's good to go.
41102b5
to
ba80941
Compare
onChange={(_event, value) => handleFilterChanged(value)} | ||
onClear={() => handleFilterChanged('')} /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These 2 added lines are not executed by any test. Details
PR looks good from my side but the tests fail everywhere, it looks like you will need to adjust how test for the value of the search input:
|
You are right, using the SearchInput component changes the structure of dom elements compared to using simple TextInput component. Now the input box will be accessible by selector
|
To get the test running should be fairly easy:
|
Hey @shubhit7 do you still intend to work on this? |
Fixes #1216
FormSelect
toSelect
next component of patternfly alpha release. OldSelect
has been deprecated.TextInput
toSearchInput
.