Dont show system session for user #1917
Open
+27
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A limited access user cannot create a system session virtual machine so this would just throw an error after creation.
jelly
force-pushed
the
dont-show-system-session-for-user
branch
from
b3dcf68
to
54f83f0
Compare
martinpitt
reviewed
Nov 27, 2024
Comment on lines
+2805
to
+2807
| b.click("#create-new-vm") | ||
| b.wait_visible("#create-vm-dialog") | ||
| b.wait_not_present("#connection") |
There was a problem hiding this comment.
Do we have any other test which covers VM creation in unprivileged mode? If so, this would better fit there. If not, that's a major gap indeed, and this test should actually create the VM and check that it starts and boots fine (including the "wait for login prompt").
There was a problem hiding this comment.
I believe this is confusingly what TestMachinesLifecycle does:
def _testBasic(self, user=None, superuser=True, expect_empty_list=False, run_pixel_tests=False):
b = self.browser
m = self.machine
# We want no initial watchdog
args = self.createVm("subVmTest1", os="linux2016")
self.login_and_go("/machines", user=user, superuser=superuser)
So we can drop this test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This throws an error when trying to create a system session vm as limited user.