Improve rendering of VM descriptions #1901
Merged
+11
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like this this, for example:
The last line has no spaces in it at all, and is broken in the middle of words to avoid overflow. The second to last line is long but has spaces. It is broken between words to avoid overflow. |
Render the description as a single paragraph, with preserved line breaks and word breaking on overflow. Fixes cockpit-project#1888, cockpit-project#1890.
mvollmer
force-pushed
the
improve-description-formatting
branch
from
d9d9051
to
4b430e8
Compare
garrett
approved these changes
Nov 18, 2024
Comment on lines
+106
to
+109
| .vm-description { | ||
| white-space: pre-wrap; | ||
| overflow-wrap: break-word; | ||
| } |
There was a problem hiding this comment.
We could also have a hyphens: auto; in there; it's relatively new-ish in baseline 2023 and will hyphenate things it needs to wrap with break-word.
https://developer.mozilla.org/en-US/docs/Web/CSS/hyphens
The hyphens CSS property specifies how words should be hyphenated when text wraps across multiple lines. It can prevent hyphenation entirely, hyphenate at manually-specified points within the text, or let the browser automatically insert hyphens where appropriate.
jelly
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Render the description as a single paragraph, with preserved line breaks and word breaking on overflow.
Fixes #1888, #1890.