Skip to content

Commit

Permalink
css: move CSS declarations above nested rules
Browse files Browse the repository at this point in the history
The new SASS version warns that decelerations should appear above nested
rules. This change should not have any visual impact.

> ▲ [WARNING] Sass's behavior for declarations that appear after nested
rules will be changing to match the behavior specified by CSS in an upcoming
version. To keep the existing behavior, move the declaration above the nested
rule. To opt into the new behavior, wrap the declaration in `& {}`.
  • Loading branch information
jelly authored and martinpitt committed Aug 19, 2024
1 parent 84c27d8 commit 6fdf21b
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 9 deletions.
12 changes: 6 additions & 6 deletions src/components/storagePools/storagePoolList.scss
Original file line number Diff line number Diff line change
@@ -1,4 +1,10 @@
#storage-pools-listing {
// Approximate size of text
// (overflows work, but will knock out alignment)
--progress-text: 8rem;
--progress-bar-min: 2rem;
--progress-bar-max: 12vw;

.pf-v5-c-table tbody > tr > * {
// These tables are 1 row tall; progress bar does odd stuff for alignment;
// vertical alignment makes text line up
Expand All @@ -10,12 +16,6 @@
margin-block-start: 0;
}

// Approximate size of text
// (overflows work, but will knock out alignment)
--progress-text: 8rem;
--progress-bar-min: 2rem;
--progress-bar-max: 12vw;

td[data-label="Size"] {
> .pf-v5-c-progress {
// Fix progress bar size
Expand Down
6 changes: 3 additions & 3 deletions src/components/vm/vmReplaceSpiceDialog.scss
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
.spice-replace-dialog-panel {
// separate it a bit from the text above
margin-block-start: var(--pf-v5-global--spacer--md);

// drop excessive inside spacing
.pf-v5-c-panel__main-body {
padding-block-start: 0;
padding-block-end: 0;
padding-inline-start: 0;
padding-inline-end: 0;
}

// but separate it a bit from the text above
margin-block-start: var(--pf-v5-global--spacer--md);
}

.spice-replace-dialog-popover-list {
Expand Down

0 comments on commit 6fdf21b

Please sign in to comment.