Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Split 9mm 45acp pistols #39

Closed
wants to merge 17 commits into from
Closed

WIP: Split 9mm 45acp pistols #39

wants to merge 17 commits into from

Conversation

macinsight
Copy link
Collaborator

@macinsight macinsight commented Nov 24, 2023

This PR is related to issue #38, focusing on expanding the current models by introducing two new ones, namely Pistol<item>_9 for 9mm caliber pistols and Pistol<item>_45 for .45 ACP caliber pistols, using GenericPistol as a base for item types.

Currently WIP, will unmark once finished, then hand over to @coavins for testing and review.

Note for testing this build: The current "Master" build of my fork automatically publishes to a hidden Steam Workshop item for easier testing.

@macinsight macinsight closed this by deleting the head repository Nov 24, 2023
@coavins
Copy link
Owner

coavins commented Nov 24, 2023

Wow, that workshop.yml is really convenient. I didn't know you could do that.

Are you planning to reintroduce these changes in another PR?

@macinsight
Copy link
Collaborator Author

macinsight commented Nov 25, 2023

Wow, that workshop.yml is really convenient. I didn't know you could do that.

Are you planning to reintroduce these changes in another PR?

If you’re referring to the 9mm/45acp split, working on that atm, starting with a 45acp model.

if you’re referring to the workshop.yml, sure, I’ll branch off of your master and add it.

If you’re going the auto-integration route, I’d suggest protecting the master-branch and shifting general development into a development-branch, so you can configure the action to only push to steam when a new release is packaged based off of master, would streamline the process a bit without auto-pushing on each build as it’s currently configured. If you want, I can add ya on steam for the devel-build. I’ll open an issue to discuss that approach further.

@macinsight
Copy link
Collaborator Author

Update: See #41 for the issue discussing the new workflow with the automation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants