-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Split 9mm 45acp pistols #39
Conversation
Add workflow to push fork to workshop as hidden item
Change action to use defined path and not folder root
Add path
This reverts commit 2fabfee.
Signed-off-by: macinsight <[email protected]>
Signed-off-by: macinsight <[email protected]>
Signed-off-by: macinsight <[email protected]>
Signed-off-by: macinsight <[email protected]>
Signed-off-by: macinsight <[email protected]>
Signed-off-by: macinsight <[email protected]>
Signed-off-by: macinsight <[email protected]>
Signed-off-by: macinsight <[email protected]>
Signed-off-by: macinsight <[email protected]>
Signed-off-by: macinsight <[email protected]>
Wow, that workshop.yml is really convenient. I didn't know you could do that. Are you planning to reintroduce these changes in another PR? |
If you’re referring to the 9mm/45acp split, working on that atm, starting with a 45acp model. if you’re referring to the workshop.yml, sure, I’ll branch off of your master and add it. If you’re going the auto-integration route, I’d suggest protecting the master-branch and shifting general development into a development-branch, so you can configure the action to only push to steam when a new release is packaged based off of master, would streamline the process a bit without auto-pushing on each build as it’s currently configured. If you want, I can add ya on steam for the devel-build. I’ll open an issue to discuss that approach further. |
Update: See #41 for the issue discussing the new workflow with the automation. |
This PR is related to issue #38, focusing on expanding the current models by introducing two new ones, namely
Pistol<item>_9
for 9mm caliber pistols andPistol<item>_45
for .45 ACP caliber pistols, usingGenericPistol
as a base for item types.Currently WIP, will unmark once finished, then hand over to @coavins for testing and review.
Note for testing this build: The current "Master" build of my fork automatically publishes to a hidden Steam Workshop item for easier testing.