-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add e2e testing base on docker-compose #647
base: master
Are you sure you want to change the base?
Conversation
9960ca0
to
705980a
Compare
hi @JacieChao I'm wondering if you have free time to review this PR. |
Thanks for your contribution @LinuxSuRen |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for the information. The author of the buildx plugin is using @Jason-ZW Github action is fine but I think it is better to reuse drone to do e2e testing in this project. Or just do e2e testing in tag/rc stage to reduce the Github action workflow runs. From my opinion, It would be better to define e2e test target in |
Yes, We have not enough quota to do pull request GitHub action e2e test, reuse drone and do e2e testing in tag stage is better. Dapper has a certain learning and usage cost for contributors, perhaps @JacieChao @orangedeng you guys can help optimize the PR with use Dapper. |
By the way, running e2e test in GitHub Action is pretty quick. Below is an example. It only takes around 3m. So, it might do not need a lot quota for that. https://github.com/halo-dev/halo/actions/runs/7081623919/job/19271232227 |
The following logs are run with docker-compose.yml with autok3s v0.9.1. I am not sure it is passed or not.
There are serial issues needed to be addressed:
|
The following command will return the exit code if there are some errors happen.
All the test cases passed as show in your log output. But I don't know how the error reproduce:
Currently, we can see the result from the table. And see the each test case if there is an error. And I think it could have a new feature to report a summary. Such as:
Currently, we could add the post to do that. Please allow me to do more tests. |
I'm not familar with drone. So, just provide a GitHub Action script to run the testing. Please comment below if you have any suggestions about the e2e testing. Consider there are a lot of APIs, I just added some of them.
By the way, the following project (drone plugin) was archived.
close #646
the related issue is #9