Fix division overflow in "Trivial per triangle" for 0-area faces. Fixes

#1557
cnr-isti-vclab · Dec 14, 2024 · 694483c · 694483c
1 parent ad55b47
commit 694483c
Showing 1 changed file with 7 additions and 2 deletions.
diff --git a/src/meshlabplugins/filter_texture/filter_texture.cpp b/src/meshlabplugins/filter_texture/filter_texture.cpp
@@ -504,12 +504,17 @@ std::map<std::string, QVariant> FilterTexturePlugin::applyFilter(
 			}
 
 			// Creates buckets containing each halfening level triangles (a histogram)
-			int    buckSize = (int)ceil(log_2(maxArea/minArea) + DBL_EPSILON);
+			// Using the logarithm law
+			//       log_2(maxArea / minArea)
+			//     = log_2(maxArea) - log_2(minArea)
+			// but the latter does not overflow the division if `minArea = DBL_MIN`
+			// as set above for `area == 0`.
+			int    buckSize = (int)ceil(log_2(maxArea) - log_2(minArea) + DBL_EPSILON);
 			std::vector<std::vector<uint> > buckets(buckSize);
 			for (uint i=0; i<areas.size(); ++i)
 				if (areas[i]>=0)
 				{
-					int slot = (int)ceil(log_2(maxArea/areas[i]) + DBL_EPSILON) - 1;
+					int slot = (int)ceil(log_2(maxArea) - log_2(areas[i]) + DBL_EPSILON) - 1;
 					assert(slot < buckSize && slot >= 0);
 					buckets[slot].push_back(i);
 				}