Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement updated PyProjectToml #854

Merged
merged 1 commit into from
Nov 19, 2023
Merged

Implement updated PyProjectToml #854

merged 1 commit into from
Nov 19, 2023

Conversation

cnpryer
Copy link
Owner

@cnpryer cnpryer commented Nov 16, 2023 •
edited
Loading

Closes #852
Closes #628
Closes #594

Replaces Metadata with new PyProjectToml backed by toml_edit for LocalMetadata.

Helps with:

TODO:

  • check out upstream a Table to pyproject-toml
  • check out hybrid solution
  • implement toml_edit wrapper
  • implement .formatted()
  • tests
  • update scripts init

@cnpryer cnpryer mentioned this pull request Nov 17, 2023
Open
@cnpryer cnpryer force-pushed the pyproject-toml branch 26 times, most recently from 844e435 to 33bf3a7 Compare November 18, 2023 07:32
@cnpryer

This comment was marked as outdated.

Sign in to view
@cnpryer cnpryer force-pushed the pyproject-toml branch 2 times, most recently from 564975a to b07e6a4 Compare November 18, 2023 17:59
@cnpryer cnpryer force-pushed the pyproject-toml branch 2 times, most recently from b9d59cc to 45bdbea Compare November 18, 2023 19:38
cnpryer
cnpryer commented Nov 18, 2023
View reviewed changes
crates/huak-pyproject-toml/Cargo.toml Outdated
license.workspace = true

[dependencies]
pep508_rs = { workspace = true, features = ["serde", "toml"] }
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO

@cnpryer cnpryer force-pushed the pyproject-toml branch 5 times, most recently from 94b464d to e0eb605 Compare November 19, 2023 01:28
@cnpryer cnpryer changed the title Add huak-pyproject-toml Implement updated PyProjectToml Nov 19, 2023
@cnpryer cnpryer force-pushed the pyproject-toml branch 4 times, most recently from 35107a6 to ea0f833 Compare November 19, 2023 03:33
@cnpryer cnpryer marked this pull request as ready for review November 19, 2023 03:34
@cnpryer cnpryer force-pushed the pyproject-toml branch 2 times, most recently from 7b3cb39 to 198e541 Compare November 19, 2023 04:17
@cnpryer cnpryer merged commit 52728eb into master Nov 19, 2023
7 checks passed
@cnpryer cnpryer deleted the pyproject-toml branch November 19, 2023 04:36
cnpryer added a commit that referenced this pull request Nov 19, 2023
@cnpryer
Implement updated PyProjectToml (#854)
7cc4b6a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@cnpryer