ioc: allow pip to install packages system-wide. #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since Debian 12, installing packages outside a virtual environment is an error by default [1] as first specified by PEP 668 [2]. The rationale for forcing this is not applicable in our context, since the container image is dedicated to the IOC under construction, which renders it an isolated environment of its own. Users should still provide RUNTIME_PIP_PACKAGES that are compatible with the system packages, not really breaking the system, similarly to what is done for shared libraries. [1] https://salsa.debian.org/python-team/packages/python-pip/-/commit/5aeba2464e36020a34e2bc074872771f5ef4973d [2] https://peps.python.org/pep-0668 Fixes: 39bb0d4 (base: update to Debian 12., 2024-10-31)
|
LGTM |
gustavosr8
approved these changes
Dec 12, 2024
ericonr
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Debian 12, installing packages outside a virtual environment is an error by default as first specified by PEP 668. The rationale for forcing this is not applicable in our context, since the container image is dedicated to the IOC under construction, which renders it an isolated environment of its own.
Users should still provide RUNTIME_PIP_PACKAGES that are compatible with the system packages, not really breaking the system, similarly to what is done for shared libraries.
Fixes: 39bb0d4 (base: update to Debian 12., 2024-10-31)