Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

base: update ipmiComm patch to handle CODE_DESTINATION_UNAVAIL. #76

Merged
merged 1 commit into from
Sep 10, 2024
Merged

base: update ipmiComm patch to handle CODE_DESTINATION_UNAVAIL. #76

merged 1 commit into from
Sep 10, 2024

Conversation

gustavosr8
Copy link
Contributor

No description provided.

@gustavosr8 gustavosr8 self-assigned this Sep 3, 2024
henriquesimoes
henriquesimoes requested changes Sep 3, 2024
View reviewed changes
Copy link
Collaborator

@henriquesimoes henriquesimoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a backport yet. Please, place it in a different file instead. Also, refer to its upstream PR in the corresponding patch file.

For the commit message, I'd rather something shorter and more direct:

base: patch ipmiComm to handle CODE_DESTINATION_UNAVAIL.

ericonr
ericonr reviewed Sep 6, 2024
View reviewed changes
Copy link
Member

@ericonr ericonr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should hold off on creating epics-in-docker releases due to ipmiComm until we have determined that everything we need is working.

CHANGES.md Outdated Show resolved Hide resolved
ericonr
ericonr approved these changes Sep 6, 2024
View reviewed changes
Copy link
Member

@ericonr ericonr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a fan of backticks in commit messages generally, especially titles.

Your choice if you want to change, though.

@gustavosr8 gustavosr8 merged commit 9d80039 into main Sep 10, 2024
2 checks passed
@gustavosr8 gustavosr8 deleted the ipmicomm-cc-unavail branch September 10, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericonr ericonr ericonr approved these changes

@henriquesimoes henriquesimoes henriquesimoes approved these changes

Assignees

@gustavosr8 gustavosr8

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gustavosr8 @henriquesimoes @ericonr