-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ioc: install busybox symbolic links. #72
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure I agree this is a fix. Why do you think it is?
Because I bet no one would use it as But I understand that is mostly an extension of the features we provided in previous images, and thus not exactly a bug fix indeed. If you still think it better fits the "new features" section, let me know. |
Commit message changes (please wrap it correctly before committing):
I think the main commit being fixed is the one that added the possibility of fetching stuff during build. Having done this for the initial busybox commit would have been helpful, but not critical. What do you think? And I don't think it makes sense to mention alpine here, since we only use debian for the IOC images. |
Make all busybox goodies directly available in PATH, to avoid having to call them from the multicall binary. This allows the removal of the wget package from the build image, since busybox provides its own version, and it's become simpler to use that. However, the version packaged by Debian does not implement the `-o` flag, requiring us to use shell redirection instead. Fixes: 8f02abc
f68f3ff
to
b7fdf8d
Compare
I understand you point, but I also meant users
I agree on this one. Referencing it made sense for me at start because I was troubled about why we did not need to install it in alpine as we did for |
95c0419
to
8fc70a3
Compare
8fc70a3
to
26de85c
Compare
Make all busybox goodies available in the PATH without having to worry about them being from busybox. This is done automatically for Alpine, but not for Debian.
This removes the need to install wget, since it is already provided by busybox. However, its version packaged by Debian does not implement
-o
flag, requiring us to use bash redirection instead.Fixes: ffdbecc (ioc: initial commit.)