base: remove CALC dependency on Sequencer #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch version was skipped in the changelog, and following modules entered in the wrong version header. Retroactively correct this, so that documentation corresponds to the history.
By making Calc depend on Sequencer, all IOCs which directly or indirectly depend on Calc must explicitly link against Sequencer library when using static-link target. This means most previously dynamic-linked IOCs will not cleanly build without changes to src/Makefile when moving to epics-in-docker. In turn, we gain the feature of editing sseq records at runtime [1], which is not used by IOCs we currently maintain and is probable not to be used by future ones. Drop support for editSseq in favor of making it easier to containerize new IOCs. This reverts commit a2096ba. [1]: https://github.com/epics-modules/calc/blob/R3-7-5/calcApp/src/calcSupport_withSNCSEQ.dbd
flowln
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By making Calc depend on Sequencer, all IOCs which directly or indirectly depend on Calc must explicitly link against Sequencer library when using static-link target. This means most previously dynamic-linked IOCs will not cleanly build without changes to src/Makefile when moving to epics-in-docker. In turn, we gain the feature of editing sseq records at runtime, which is not used by IOCs we currently maintain and is probable not to be used by future ones.
Drop support for editSseq in favor of making it easier to containerize new IOCs.
This reverts commit a2096ba.