ioc: configure static link directly on CONFIG_SITE. #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modern EPICS templates defines an optional include to a `.local` version of the configuration files. However, it is not guaranteed that this haven't been removed in the IOC, or that another template was used, which does not contain this logic. In such situations, compiling will succeed if we place STATIC_BUILD in the local file, but the IOC won't be statically linked, as the configuration won't ever be loaded. Use CONFIG_SITE directly to avoid mistakenly compiling an application with dynamic linking when the used target is `static-link` and the template does not include local settings. This also lowers the knowledge required about the EPICS build system to successfully build the IOCs. Note that appending to the end of CONFIG_SITE will correctly override any configuration in CONFIG_SITE.local if there is any.
ericonr
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modern EPICS templates defines an optional include to a
.localversion of the configuration files. However, it is not guaranteed that this haven't been removed in the IOC, or that another template was used, which does not contain this logic. In such situations, compiling will succeed if we place STATIC_BUILD in the local file, but the IOC won't be statically linked, as the configuration won't ever be loaded.Use CONFIG_SITE directly to avoid mistakenly compiling an application with dynamic linking when the used target is
static-linkand the template does not include local settings. This also lowers the knowledge required about the EPICS build system to successfully build the IOCs.Note that appending to the end of CONFIG_SITE will correctly override any configuration in CONFIG_SITE.local if there is any.