-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pmac module version update, add motorPIGCS2 and MCA IOC #64
Conversation
91c882f
to
43d40ec
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How soon do you need these?
It would be nice to have module pruning added before we merge so many new images.
b03ef7a
to
cfad10d
Compare
567231f
to
8edf8da
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the long delay. Having a second look after some time, I've found some minor details yet to be fixed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good for me now.
1217ea4
to
ee49ed3
Compare
A pre-release version is used because important bug fixes have not yet been released, including segmentation fault when the coordinate system axis object does not exist, and assignment of null offset values upon Delta Tau reconnection.
I've complemented the commit messages, and reworded somethings to be consistent with our previous commits. I've also recreated the scaler module commit, which was squashed by mistake during the latest rebase. |
Typo in 913c778 commit message
|
I don't think I get the message in 4834166, but I think it may be re-written like this:
|
Build motorPIGCS2 module from epics-modules/motor. Using a specific commit is necessary because the latest changes have not been yet released. However, these changes have been successfully running in deploy at Carnauba for almost a year. Since we use the community module without extra libraries linked to the IOC, build the IOC as an epics-in-docker image.
Some IOCs need their own path location variable in the RELEASE file during build. To avoid custom installation procedures for them, add "dependency_name" to the EPICS_RELEASE_FILE before overwriting the module RELEASE file during `install_module`.
Even though our primary usage will initially be for Amptek devices, everything in the module is build as defined by the community. Both libpcap and libnet are required to build MCA support for Canberra Ethernet acquisition devices. Therefore, the IOC image also installs these runtime dependencies.
No description provided.