images: add OPCUA image. #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
images/docker-compose-opcua.yml
Outdated
Comment on lines
11
to
12
| REPONAME: opcua | ||
| RUNDIR: /opt/epics/modules/opcua |
There was a problem hiding this comment.
If we are going to use #59, we should be careful when defining these variables. By implementing the suggestion of dropping the RUNDIR as input to keep binaries, REPONAME should point to epics/modules/opcua instead. There is no such /opt/opcua directory in no-build targets as of now.
An alternative approach could be to symbolic link or hard-copy during the pruning stage of no-build.
henriquesimoes
requested changes
May 8, 2024
Since the OPCUA IOC we use is built alongside the OPCUA module, we can simply export the IOC image ourselves.
This workflow will only run for tags for now, since otherwise it would
have to deal with relying on a ${tag}-dev container for the base image.
If we add more included images, we can add a matrix to the workflow
definition to build all their images.
This commit was based on [1].
[1] https://stackoverflow.com/questions/58457140
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the OPCUA IOC we use is built alongside the OPCUA module, we can simply export the IOC image ourselves.
This is still missing automatic generation of the image in CI. Creating the tagged image is easy, we just need to depend on the workflow which pushes the base image. The hard part is running it for PRs as well... This means it probably has to be in the same workflow and must deal with the recently built base image which will have its own name but should be called
X.Y.Z-dev.I'm not sure how far we need to go before merging and tagging a release so it can be used.