base: use RELEASE to determine module paths. #48
Conversation
There was a problem hiding this comment.
Nits:
"base: use RELEASE to determine module paths."
"..., each module adds its..."
"Therefore, it's possible to use the RELEASE file as the source of truth for our dependencies' paths"
"This removes duplication of several module paths, which may now be changed more easily."
That last phrase makes me feel like we are going to be changing a whole lot of paths :p Is that why you mentioned this being related to the final container cleanup?
henriquesimoes
force-pushed
the
mod-path
branch
from
29463ee to
d52fa29
Compare
Thanks!
Yep. That's the point. Not sure if we'll really need to move things around, but it is now easier to do so if the decide this is the best option. Nevertheless, having a single point for defining such things diminishes our chances of making mistakes. ;) |
henriquesimoes
changed the title
Calc module conditionally adds support to Sequencer based on the definition of SNCSEQ and not SEQ. Fixes: 0183021 ("base: initial commit.")
henriquesimoes
force-pushed
the
mod-path
branch
from
d52fa29 to
3afb6bf
Compare
Right after being installed, each module adds its own path to the RELEASE file. Therefore, it is possible to use the RELEASE file as the source of truth for our dependencies' paths. Since a module cannot be built without its dependency already built, this does not limit our installation scripts. This removes duplication of several module paths, which may now be changed more easily. If a non-existent dependency is provided and errexit (-e) bash option is set, the script will fail during the get_module_path's grep call due to its non-zero exit code.
henriquesimoes
force-pushed
the
mod-path
branch
from
3afb6bf to
525753f
Compare
Right after being installed, a module adds its own path to the RELEASE file. Use this as the source of truth for specifying the dependencies' path in later module builds. Since a module cannot be built without its dependency already built, this does not limit our installation scripts.
This removes duplication of several paths of modules, which may now change more easily.